Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag is incremented even if it does not follow the convention. #126

Open
defgenx opened this issue Nov 26, 2024 · 0 comments
Open

Tag is incremented even if it does not follow the convention. #126

defgenx opened this issue Nov 26, 2024 · 0 comments

Comments

@defgenx
Copy link
Contributor

defgenx commented Nov 26, 2024

In the current code base there's a fallback rule in case it doesn't match any type of the chosen convention:

// fallback to patch bump if no matches from the scheme parsers
if b != nil {
   return b.bump(r.currentVersion)
}

In some cases we don't want to tag when parseAutotagCommit or parseConventionalCommit return nil.

I think we could add an option allowing to disable the fallback, but it looks too much like a workaround to me...
I would rather remove the fallback and add an option to allow a list of "extra" types on which we would like to bump a patch version, or another possibility would be to add a configuration file. It means we need to agree on the format, fields and everything so it's maybe not the best option.

What do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant