You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the current code base there's a fallback rule in case it doesn't match any type of the chosen convention:
// fallback to patch bump if no matches from the scheme parsersifb!=nil {
returnb.bump(r.currentVersion)
}
In some cases we don't want to tag when parseAutotagCommit or parseConventionalCommit return nil.
I think we could add an option allowing to disable the fallback, but it looks too much like a workaround to me...
I would rather remove the fallback and add an option to allow a list of "extra" types on which we would like to bump a patch version, or another possibility would be to add a configuration file. It means we need to agree on the format, fields and everything so it's maybe not the best option.
What do you think ?
The text was updated successfully, but these errors were encountered:
In the current code base there's a fallback rule in case it doesn't match any type of the chosen convention:
In some cases we don't want to tag when
parseAutotagCommit
orparseConventionalCommit
returnnil
.I think we could add an option allowing to disable the fallback, but it looks too much like a workaround to me...
I would rather remove the fallback and add an option to allow a list of "extra" types on which we would like to bump a patch version, or another possibility would be to add a configuration file. It means we need to agree on the format, fields and everything so it's maybe not the best option.
What do you think ?
The text was updated successfully, but these errors were encountered: