Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_state_rviz_plugin): check for abrupt deceleration #9474

change accent color to Freak Pink

406cef1
Select commit
Loading
Failed to load commit list.
Merged

feat(tier4_state_rviz_plugin): check for abrupt deceleration #9474

change accent color to Freak Pink
406cef1
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 29, 2024 in 40s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.32 (9.59 -> 9.27)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional velocity_steering_factors_panel.cpp: VelocitySteeringFactorsPanel::onVelocityFactors
  • Complex Method velocity_steering_factors_panel.cpp: VelocitySteeringFactorsPanel::onVelocityFactors

Annotations

Check warning on line 210 in common/tier4_state_rviz_plugin/src/velocity_steering_factors_panel.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

VelocitySteeringFactorsPanel::onVelocityFactors has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 202 in common/tier4_state_rviz_plugin/src/velocity_steering_factors_panel.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

VelocitySteeringFactorsPanel::onVelocityFactors has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.