Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug related to architectural register write stats #47

Open
hayesti opened this issue Sep 23, 2015 · 0 comments
Open

Small bug related to architectural register write stats #47

hayesti opened this issue Sep 23, 2015 · 0 comments

Comments

@hayesti
Copy link

hayesti commented Sep 23, 2015

In ooo-pipe.cpp::ReorderBufferEntry::commit() I have found a small bug.

if likely (archdest_can_commit[uop.rd]) {
    thread.commitrrt[uop.rd]->uncommitref(uop.rd, thread.threadid);
    thread.commitrrt[uop.rd] = physreg;
    thread.commitrrt[uop.rd]->addcommitref(uop.rd, thread.threadid);

    if likely (uop.rd < ARCHREG_COUNT) {
        ctx.set_reg(uop.rd, physreg->data);
    }

    if unlikely (opclassof(uop.opcode) == OPCLASS_FP)
        thread.thread_stats.fp_reg_writes++;
    else
        thread.thread_stats.reg_writes++;

    thread.thread_stats.physreg_reads[physreg->rfid]++;

    physreg->rob = NULL;
}

This line

if unlikely (opclassof(uop.opcode) == OPCLASS_FP)

should be changed to

if unlikely (isclass(uop.opcode, OPCLASS_FP))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant