Things to note about current state of 2.0 feature branch

[Arkemlar]

A note for those who wants to contribute to this repo (and probably me too).
While digging into feature/2.0 brunch following inconsistent things has been found:

• Event/ThemeEvents.php: remove or make used event const THEME_SIDEBAR_SEARCH (unused now). Remove const THEME_SIDEBAR_ACTIVATE_MENU since it is also never used and not documented.
• Controller/SecurityController: not used because Resources/config/security.yml route file never included or described in docs, needs doc or remove (sine its code is same as in symfony doc).
• Controller/ExceptionController: not documented (but used as I suppose). Contains weird code for very specific use cases.
• Form/FormHelpExtension: the purpose of this form extension is unclear (at least for me)
• Model/UserInterface->isOnline() the method is never used (remove?)
• Route with login alias required but not documented here. However, documented alias logout not used (since logout_path) used instead.
• avanzu_logo_path and avanzu_navbar_toggle blocks are not exists (requires doc page fix)

Documentation not up to date: some documented defaults are not actually defaults and some options not documented at all, here are full options with defaults (dump):

    "skin" => "skin-blue"
    "fixed_layout" => false
    "boxed_layout" => false
    "collapsed_sidebar" => false
    "mini_sidebar" => false
    "control_sidebar" => true
    "default_avatar" => "bundles/avanzuadmintheme/img/avatar.png"
    "widget" => array:8 [▼
      "type" => "primary"
      "bordered" => true
      "collapsible" => true
      "collapsible_title" => "Collapse"
      "removable" => true
      "removable_title" => "Remove"
      "solid" => false
      "use_footer" => true
    ]
    "button" => array:2 [▼
      "type" => "primary"
      "size" => "md"
    ]
    "knp_menu" => array:3 [▼
      "enable" => false
      "main_menu" => "avanzu_main"
      "breadcrumb_menu" => false
    ]

[shakaran]

@Arkemlar all issues per items that you commented, documentation changes are welcome in Pull Request, please, consider to make one if you can or people that read this ;) Thanks

[Arkemlar]

@shakaran I made my own local version of this bundle and there are too many changes to make it possible to merge them to this repo: I removed some things in layout base template, tied up with BraincraftedBootstrapBundle, removed avanzu form theme integration (there are another and better one in braincrafted's bundle), made improved menu breadcrumbs system and so on. Maybe later I will find some time to make repo.

[shakaran]

@Arkemlar I push some interesting changes to master if you want test (I am understanding more things, so I would document soon more code and configs).

I would like add and review your PR before to release the stable 2.0, so more users could test. If you don't have time, you can just upload your repo and put in a comment, and I can inspect and cherry pick the interesting changes. All collaboration is good to make this bundle more powerful! 💪

[Arkemlar]

@shakaran Okay, I hope I will be able to make a repo in this week - there are a little refactoring needed first.

[Arkemlar]

@shakaran I published my code there https://github.com/Arkemlar/admin-theme-bundle, take a look to KnpMenu directory, it contains extended menu system.