Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument error reporting for config passed from application is at run time change it to compile time #3

Closed
pkrawat1 opened this issue Dec 19, 2017 · 1 comment

Comments

@pkrawat1
Copy link
Member

pkrawat1 commented Dec 19, 2017

Config related-error reporting was introduced in #7 and currently happens at runtime, before every call to Gringotts API.
We should validate the config at compile time to reduce the overhead.

@pkrawat1 pkrawat1 self-assigned this Dec 21, 2017
@pkrawat1 pkrawat1 added this to the Release 1.5.0 milestone Dec 21, 2017
@pkrawat1 pkrawat1 removed this from the Release 1.5.0 milestone Jan 25, 2018
@oyeb
Copy link
Contributor

oyeb commented Jun 4, 2018

Hmm, this is do-able, but it can cause problems when the user explicitly wants to pass in some credentials or different config at run-time (for example in #41).
Moreover, the config may not be available at compile time if some service is going to populate it at runtime (imagine some custom deployment setup where these credentials are fetched from a remote resource).

Also, the Application config is designed to be really fast (it is backed by :ets) so this is not really an overhead.

@oyeb oyeb closed this as completed Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants