Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

did:peer can't comply with didcommv2 #3

Closed
brianorwhatever opened this issue Oct 14, 2022 · 5 comments
Closed

did:peer can't comply with didcommv2 #3

brianorwhatever opened this issue Oct 14, 2022 · 5 comments

Comments

@brianorwhatever
Copy link
Contributor

The service property of did:peer doesn't align with what is required from didcomm v2.. If we go the did:peer approach we will either have to misalign with didcomm or did:peer

@brianorwhatever
Copy link
Contributor Author

I have created a did:peer library that to the best of my knowledge should interoperate with the python did:peer library. If we go this route we can interoperate between typescript & python however it is not conforming to either the did core spec or didcomm v2 spec.

https://github.com/aviarytech/did-peer

@vongohren
Copy link

@brianorwhatever sorry for not responding, I was primarily following the working sheet.

But is this still an issue? Please add to concerns

@brianorwhatever
Copy link
Contributor Author

I don't think it is an issue anymore it is just sad we don't comply to didcomm v2 service endpoints.. I will be tracking this issue in aviarytech/did-peer#2

@2byrds
Copy link

2byrds commented Oct 28, 2022

@brianorwhatever can you post some detail about complying with didcomm v2 service endpoints. i'd like to capture pain points related to did:peer and didcomm v2 since that is the most likely pairing.

@brianorwhatever
Copy link
Contributor Author

yeah it's basically like this:

did:peer service block

{
  "type": "DIDCommMessaging",
  "serviceEndpoint": "https://example.com/endpoint",
  "routingKeys": ["did:example:somemediator#somekey"],
  "accept": ["didcomm/v2", "didcomm/aip2;env=rfc587"]
}

didcomm v2 service block

{
    "id": "did:example:123456789abcdefghi#didcomm-1",
    "type": "DIDCommMessaging",
    "serviceEndpoint": [{
        "uri": "https://example.com/path",
        "accept": [
            "didcomm/v2",
            "didcomm/aip2;env=rfc587"
        ],
        "routingKeys": ["did:example:somemediator#somekey"]
    }]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants