When/How does this package get new releases? #16
Comments
|
Well, the first step is to update the jll in Yggdrasil, and then test this package with the new jll for API breakages. |
|
Ok. I have a few more follow up questions on that:
|
|
1. Yes. If you see the minifb build file (
https://github.com/JuliaPackaging/Yggdrasil/blob/master/M/MiniFB/build_tarballs.jl)
on yggdrasil right now, we just refer to the master when it was
last updated.
2. Yeah, sure. Why not.
3. Yeah, that sounds about right.
…On Sat, 19 Feb 2022, 06:53 Siddharth Bhatia, ***@***.***> wrote:
Ok. I have a few more follow up questions on that:
1. I don't see any version releases on minifb repository
<https://github.com/emoon/minifb>. Do we just take the current master
branch?
2. What would be a good time to update the jll and MiniFB.jl? I
believe there are some bug fixes that have occurred since the last time
this package was update (eg. ***@***.***
<emoon/minifb@0e493a7>).
Would it be a good idea to update this package right now?
3. Since there are no automated tests, would it be okay to just test
the examples (with more examples added over time) on the different
platforms (Windows, macOS, Linux)? I can help with testing on Linux (I am
using Manjaro Linux), if needed.
—
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4QJTXKFOFYUFUBOCQLBDU3446RANCNFSM5OVNKNEQ>
.
You are receiving this because you commented.Message ID: <aviks/MiniFB.
***@***.***>
|
|
Great! Thanks. |
|
Hi @aviks . I am trying to create a tarball for my host platform with the latest minifb commit using the following script: # Note that this script can accept some limited command-line arguments, run
# `julia build_tarballs.jl --help` to see a usage message.
using BinaryBuilder, Pkg
name = "MiniFB"
version = v"0.2.0"
# Collection of sources required to complete build
sources = [
GitSource("https://github.com/emoon/minifb.git", "5066489cd81b23b0c79952f7d6f464b20c54867c") #master as of 24Feb2022
]
# Bash recipe for building across all platforms
script = raw"""
cd $WORKSPACE/srcdir/minifb/
sed -i -e 's/add_library(minifb STATIC/add_library(minifb SHARED/' \
-e 's/ -Wall/-I$ENV{includedir} -Wall/' \
CMakeLists.txt
mkdir build && cd build
cmake -DCMAKE_INSTALL_PREFIX=${prefix} \
-DCMAKE_TOOLCHAIN_FILE=${CMAKE_TARGET_TOOLCHAIN} \
-DCMAKE_BUILD_TYPE=Release \
-DMINIFB_BUILD_EXAMPLES=OFF \
..
make -j${nproc}
mv libminifb* ${libdir}
"""
# These are the platforms we will build for by default, unless further
# platforms are passed in on the command line
# platforms = supported_platforms()
platforms = [HostPlatform()]
# The products that we will ensure are always built
products = [
LibraryProduct("libminifb", :libminifb)
]
# Dependencies that must be installed before this package can be built
dependencies = [
Dependency(PackageSpec(name="Xorg_libX11_jll", uuid="4f6342f7-b3d2-589e-9d20-edeb45f2b2bc"))
BuildDependency(PackageSpec(name="Xorg_xorgproto_jll", uuid="c4d99508-4286-5418-9131-c86396af500b"))
]
# Build the tarballs, and possibly a `build.jl` as well.
build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; preferred_gcc_version = v"5.2.0")But I am getting the following error (my guess is that it is related to some dependency that needs to be added but I don't know how to resolve it): I am using the following configuration: julia> versioninfo()
Julia Version 1.7.1
Commit ac5cc99908 (2021-12-22 19:35 UTC)
Platform Info:
OS: Linux (x86_64-pc-linux-gnu)
CPU: Intel(R) Core(TM) i7-6500U CPU @ 2.50GHz
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-12.0.1 (ORCJIT, skylake)
(build) pkg> st
Status `~/projects/SimpleIMGUIExample/build/Project.toml`
[12aac903] BinaryBuilder v0.5.2
(build) pkg> Could you please help me out here? Also, I was wondering if there are any updates on progress towards a newer minor release of Thanks. |
|
@Sid-Bhatia-0 see here: JuliaPackaging/Yggdrasil#4533 |
|
Hi @aviks. I see that the jll at https://github.com/JuliaBinaryWrappers/MiniFB_jll.jl has been updated. Can we now tag a new release for this package? Thanks. |
|
Actually, we do not have a compat bound for the jll in the project.toml, so if you update, you should get the new jll. We need to test if the examples all work on the new jll. |
|
Ok. I tried a fresh install. It installs the latest jll. And all the 4 examples seem to be running on my machine. Also, could there be a change in the API that requires modifying the files in I tried getting the Thanks. |
|
Sorry, I missed the last comment. I don't think there are any API changes, as far as I know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all, thank you for creating this wrapper package. I really like the simplicity of minifb.
On the minifb repository, I see commits in the source code that are more recent than the last release of
MiniFB.jl.I am not familiar with how
MiniFB.jlwas created from minifb, so this is a beginner level question. I am curious to know when and how wouldMiniFB.jlincorporate changes from the original minifb library? I saw that there is MiniFB_jll, but even over there, the last commit seems to be long back.Thanks.
The text was updated successfully, but these errors were encountered: