Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with unique constraint on PhoneNumber concept #1547

Open
mahalakshme opened this issue Nov 20, 2024 · 2 comments
Open

Issues with unique constraint on PhoneNumber concept #1547

mahalakshme opened this issue Nov 20, 2024 · 2 comments

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Nov 20, 2024

Need:

Since the project is going to be at scale, these kind of UX issues need to be resolved.

As is:

  • Currently unique check is working on Numeric, Text and Phone Number concept(when verification disabled).
  • Unique check on Mobile number happening only against non voided entries
  • Also it shows the error message that 'Another {subject type name} has the same value' when clicked on Next

Issue:

  • When unique check on PhoneNumber concept applied for which verification is enabled, then, 'Verify Mobile Number' button is not showing up.
  • Validation error messages 'Invalid phone number' are not getting updated on Phone Number when unique constraint is enabled as the number is typed

https://drive.google.com/file/d/1a87qnfdlIUhKdLBzTxIWxuq-RCyfvZ-e/view?usp=drive_link

  • As you can see below when only mobile verification is there 'Invalid Mobile Number' error message disappears and 'Verify Mobile Number' button appears

https://drive.google.com/file/d/128W0zCYzbmGnoHgpu-YIFNEkI9OAuqFa/view?usp=drive_link

  • When only unique constraint is there, 'Invalid phone number' doesn't get updated even after typing a valid one, and doesn't show the unique constraint violation immediately and appears only on clicking 'Next'

https://drive.google.com/file/d/1i2uLgMfObWtM5gPo0LN54_BlBVS5fPce/view?usp=drive_link

AC:

  • When value for concept whose type is 'Phone Number' is entered, when less than 10 or more digits is there, need to show 'Invalid Phone Number'. But once typed 10 digits this error message should disappear - even when only unique check enabled or when also verification enabled
  • When unique constraint enabled and once a valid number is typed and if it is a duplicate, need to show 'Another {subject type name} has the same value' and need not wait until Next is clicked. Also once the unique constraint is satisfied the error message should be removed.
  • When verification enabled, and when both above issues not there, then 'Verify Mobile Number' button need to show beside. Needed for UX since there are other mobile numbers in the same page.

Technical analysis:

Looks like when 'Invalid phone number' error message is removed from the state, the rest 2 ACs will get satisfied.

Code link for the above root cause

@mahalakshme mahalakshme converted this from a draft issue Nov 20, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Nov 20, 2024
@ombhardwajj
Copy link

I would like to work on this issue @mahalakshme .
Please grant me access to view the content in those drive links!

@mahalakshme
Copy link
Contributor Author

@ombhardwajj currently the above is not fully analysed. I ve pinged you over skype to help figure out cards that are of interest to you and that are as well analysed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Analysis Review
Development

No branches or pull requests

2 participants