Feature: allow all optional props for the NodejsFunction CDK construct to be passed via defineFunction in @aws-amplify/backend-function

[ataylorme]

Problem

defineFunction does not allow all props available on NodejsFunction

Issue number, if available: #1968

Changes

• Allow passing optional props to NodejsFunction via defineFunction
• Add test to allow passing retryAttempts prop to NodejsFunction via defineFunction

Validation

I created a unit test that validates the presence of AWS::Lambda::EventInvokeConfig with MaximumRetryAttempts in the generated CloudFormation when retryAttempts is passed as a prop to defineFunction

Checklist

• If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
• If this PR requires a change to the Project Architecture README, I have included that update in this PR.
• If this PR requires a docs update, I have linked to that docs PR above.
• If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[changeset-bot]

🦋 Changeset detected

Latest commit: 1fab1ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@aws-amplify/backend-function	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[josefaidt]

Hey @ataylorme 👋 thanks for taking the time to file this and your interest in contributing! A few of these properties will require values that rely on CDK scope like VPC configuration, or enums that must be imported from CDK. Are there any particular properties you're interested in?

[ataylorme]

@josefaidt the ones I am personally interested in are the log related options (systemLogLevelV2, logRetention, logGroup, etc.), maxEventAge and retryAttempts.

Other users will have other needs, which is why I made the PR to support all options.

A few of these properties will require values that rely on CDK scope like VPC configuration, or enums that must be imported from CDK

In this case it would be up to the user to import those types/values and pass valid parameters that satisfy CDKNodejsFunctionProps

[josefaidt]

Hey @ataylorme thanks for the clarification! Coincidentally enough we have a PR filed for exposing function logging props #2245

We'll work to evaluate exposing other NodejsFunctionProps in the meantime 🙂

[ataylorme]

Oh nice! I have been manually provisioning a log group in CDK with retention settings to match the Lambda names. That PR will make it much simpler.