Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] add breakCircularDependency prop to defineFunction #2207

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rtpascual
Copy link
Contributor

@rtpascual rtpascual commented Nov 6, 2024

Changes

Adds breakCircularDependency (naming can change) to defineFunction props. If this is set to true, splits function into its own stack based on the function's name.

// amplify/auth/resource.ts

export const preSignUp = defineFunction({
   name: 'preSignUp',
   entry: './presignup/handler.ts',
  breakCircularDependency: true,
});

export const randomFunction = defineFunction({
   name: 'randomFunction',
   entry: './randomefunction/handler.ts',
});

export const auth = defineAuth({
   ...
   triggers: { preSignUp },
});
// amplify/backend.ts

export const backend = defineBackend({
  auth,
  data,
  randomFunction,
  preSignUp,
});

const randomFunctionStack = backend.randomFunction.stack; // function stack
const preSignUpStack = backend.preSignUp.stack; // presignup stack

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant