-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy integration test backends using amplify CLI in headless mode. #71
base: main
Are you sure you want to change the base?
Conversation
This pull request introduces 7 alerts and fixes 3 when merging 0837ec4 into 6834d2f - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
For the schema files, can you name them like:
events_api.graphql
person_car.graphql
team_project.graphql
blog_api.graphql
comments_blogs.graphql
Please be sure to update the high-level documentation, to mention the functionality that's available:
./README.md
./src/integ_test_resources/android/README.md
And add a new one under ./src/integ_test_resources/android/amplify/README.md
(or one of the child dirs) that talks about howto setup the Amplify resources.
Looks like we're at a point now where we can provision the API and DataStore AppSync dependencies, is that right? Cognito auth stuff, too? Do we have a way to generate configuration files for this stuff? Maybe through amplify
CLI, itself? Anyway, these are all questions I have as an interested customer of this work. It'd be great to get into a README.
Depending on how far we are now, we should also update Amplify Android's CONTRIBUTING.md
so that contributors (me, you, Susie Q) can run the tests in our own dev accounts.
REMOVE = "remove" | ||
|
||
def parse_arguments(): | ||
parser = argparse.ArgumentParser(description="Utility that runs the Amplify CLI in headless mode to provision backend resources for integration tests.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo!
This pull request introduces 7 alerts and fixes 3 when merging 5a17034 into 6834d2f - view on LGTM.com new alerts:
fixed alerts:
|
Done.
Yes...I'll work on that next.
Correct. That's currently what we are doing for the backends used by the DataStore and API tests. It configures Amplify apps with Auth and API since those two categories can be setup in headless mode via the CLI. Devs can also choose to deploy to their own account during development. I'll add instructions for that in the README.
Yes...we should be able to, but it's not currently automated. Right now, I'm manually copying the config files to the S3 bucket in the build account (which is different than the AWS accounts that host the backend). The integration tests just copy the files from there before running the build . I'm currently considering a couple options:
Both will require some level of cross-account permissions.
Yes. That should definitely make its way into that guide. |
This pull request introduces 7 alerts and fixes 3 when merging ebaaafb into 6834d2f - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 7 alerts and fixes 3 when merging c81bb18 into 6834d2f - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 7 alerts and fixes 3 when merging 6916b19 into 3bcce6b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 7 alerts and fixes 3 when merging c4ebbd2 into 3bcce6b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 7 alerts and fixes 3 when merging a457a28 into 3bcce6b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request fixes 3 alerts when merging 0cdd502 into 3bcce6b - view on LGTM.com fixed alerts:
|
This pull request introduces 1 alert and fixes 3 when merging 7aad6ba into 3bcce6b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 5 when merging 536ca37 into f961f16 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 5 when merging 2e6597b into b962c57 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 5 when merging 5421bc4 into b962c57 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 5 when merging 699b872 into eab1055 - view on LGTM.com new alerts:
fixed alerts:
|
Issue #, if available:
Description of changes:
CDK App
CDK app that creates CodeBuild projects used to build and deploy amplify backends to support the various integration test scenarios for
amplify-android
.CodeBuild assets
Scripts and other components used by the CodeBuild project. These scripts use the amplify CLI in headless mode to setup the amplify projects. Schema files are located under the schemas folder and are loosely grouped by the integration tests for each respective module in
amplify-android
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.