fix(amplify-cli-core): use build script for overrides #13858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the TypeScript compilation of overrides so that it doesn't require `node_modules/.bin/tsc`. Instead, it simply relies on the `build` script to execute `tsc`. This is more flexible and can support alternative setups w/ hoisting (e.g. via Yarn workspaces). This is an override corollary fix to aws-amplify#11854, which is for custom resources. aws-amplify#11889
2 tasks
|
@josefaidt sorry to pester, but any chance this can get some attention? Would love to be able to stop using custom builds of the CLI! Thanks! 🙏 |
|
@sobolk any chance this can get visibility? I believe it's a straight-forward and sensible change, but I'm happy to update if there's an alternative approach that would be preferred by the team. Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the TypeScript compilation of overrides so that it doesn't require
node_modules/.bin/tsc. Instead, it simply relies on thebuildscript to executetsc. This is more flexible and can support alternative setups w/ hoisting (e.g. via Yarn workspaces).This is an override corollary fix to #11854, which is for custom resources.
Description of changes
Remove hard-coded dependency on
node_modules/.bin/tscfor overrides to instead use thebuildscript frompackage.json, which is more flexible.Issue #11889
Description of how you validated changes
Ran
yarn testand all pre-commit hooks without issue.Tested
amplify build --debugandamplify pushlocally. The commands were failing on Amplify CLI12.12.4, and it succeeds with these changes in place (viaamplify-dev).Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.