Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dotnet8 support for linux image #14023

Conversation

awsluja
Copy link
Contributor

@awsluja awsluja commented Nov 21, 2024

Description of changes

Updates Linux image build to use dotnet8.
Tested build using local pipeline.

image

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@awsluja awsluja marked this pull request as ready for review November 21, 2024 19:27
@@ -147,11 +147,11 @@ FROM tools AS runtimes

#**************** .NET-CORE *******************************************************

ENV DOTNET_6_SDK_VERSION="6.0.405"
ENV DOTNET_8_SDK_VERSION="8.0.404"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be a way instal both 6 and 8 if we want backwards compatibility for some time. (think hotfixes, rollbacks in main repo).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently I am planning to be able to just create this image for testing (since the old images are not affected), ie:

  • enable way to create test image (to expedite full-e2e testing and iteration, I will use the images via overrides settings for codebuild batch until that is stable)
  • as a follow up, I can submit a PR to introduce image with multiple version of dotnet (and test with that as well using overrides); if that goes well, we can use this as final image, but currently I am not able to do much testing in bulk and want to have a standalone v8 to set a baseline

@awsluja
Copy link
Contributor Author

awsluja commented Nov 21, 2024

closing for now, there is a way to build an image from a branch without merging to /latest

@awsluja awsluja closed this Nov 21, 2024
@awsluja awsluja mentioned this pull request Nov 25, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants