Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dbsubnetgroup.DBSubnetGroup from Listing<String|Mapping> to Listing<String|Mapping>|Mapping #10

Open
henriqueleite42 opened this issue Jul 4, 2024 · 1 comment

Comments

@henriqueleite42
Copy link
Contributor

Currently, it doesn't support this kind of use:

Resources {
	["SubnetGroup"] = new dbsubnetgroup.DBSubnetGroup {
		// ...
		SubnetIds = cfn.Ref("SubnetsIds")
		// ...
	}
}

It forces you to receive multiple subnet parameters to be passed directly in a listing, like this:

Resources {
	["SubnetGroup"] = new dbsubnetgroup.DBSubnetGroup {
		// ...
		SubnetIds = new Listing {
			cfn.Ref("SubnetId1")
			cfn.Ref("SubnetId2")
			cfn.Ref("SubnetId3")
		}
		// ...
	}
}

The idea is to fix it and allow using refs directly

@ericzbeard
Copy link
Contributor

Seems like we need to do this for all array types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants