Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork origin pull requests are currently blocked #1807

Closed
bryan-aguilar opened this issue Feb 2, 2023 · 9 comments
Closed

Fork origin pull requests are currently blocked #1807

bryan-aguilar opened this issue Feb 2, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@bryan-aguilar
Copy link
Contributor

Pull Requests began to experience a high rate of failure due to throttling from Public ECR when pulling images. These throttling errors have been experiences in the past but have often been mitigated by rerunning the workflow. Recently (~1week) throttling failures continued to happen even after numerous retries.

In an attempt to mitigate this issue credentials account credentials were added to the PR Build workflow. This allows login to Public ECR so requests made are authenticated. This alleviated the issue but created a new one. Secrets are not passed to workflows. Putting the IAM Role ARN in plain text will also not solve the issue. OIDC authorization will continue to fail due to the subject claim for fork origin pull requests. This has been tested on a fork and the failing behavior has been validated.

Current Mitigation Steps: If you have write access to this repository then push your branch to this remote ref. Submit your PR and the PR Build workflow will be able to make authenticated requests to Public ECR

Possible Solutions:

  1. Remove the need to pull from ECR for mock tests. Build images for each test case or possibly once per workflow.
  2. Pull images from Public ECR once per workflow. It may be possible to do a setup step where the images are pulled once and then cached for later use.
@Aneurysm9 Aneurysm9 pinned this issue Feb 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jun 11, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been marked as stale for 30 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 16, 2023
@bryan-aguilar bryan-aguilar reopened this Jul 18, 2023
@rapphil rapphil unpinned this issue Sep 22, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Sep 24, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been marked as stale for 30 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2023
@vasireddy99 vasireddy99 removed the stale label Nov 1, 2023
@vasireddy99 vasireddy99 reopened this Nov 1, 2023
Copy link
Contributor

github-actions bot commented Jan 7, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jan 7, 2024
Copy link
Contributor

This issue was closed because it has been marked as stale for 30 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2024
@vasireddy99 vasireddy99 removed the stale label Feb 27, 2024
@vasireddy99 vasireddy99 reopened this Feb 27, 2024
@vasireddy99 vasireddy99 pinned this issue Feb 27, 2024
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Apr 28, 2024
Copy link
Contributor

github-actions bot commented Jun 2, 2024

This issue was closed because it has been marked as stale for 30 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2024
@vasireddy99 vasireddy99 removed the stale label Nov 15, 2024
@vasireddy99 vasireddy99 added the bug Something isn't working label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants