Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation are not being attached the service account #113

Open
Blunderchips opened this issue Oct 16, 2024 · 2 comments
Open

Annotation are not being attached the service account #113

Blunderchips opened this issue Oct 16, 2024 · 2 comments

Comments

@Blunderchips
Copy link

Blunderchips commented Oct 16, 2024

Looking at this value here to pass annotations down to the service accounts, it does not seem to be used anywhere in the chart?

For what I can see it is just not used anywhere. Expecting to see it being passed somewhere here:

apiVersion: v1
kind: ServiceAccount
metadata:
  labels:
    {{- include "amazon-cloudwatch-observability.labels" . | nindent 4}}
  name: {{ template "amazon-cloudwatch-observability.managerServiceAccountName" . }}
  namespace: {{ .Release.Namespace }}

What I am trying to is to attach eks.amazonaws.com/role-arn for the manager to use. But I am ending up with the following:

Name:                amazon-cloudwatch-observability-controller-manager
Namespace:           amazon-cloudwatch
Labels:              app.kubernetes.io/instance=amazon-cloudwatch-observability
                     app.kubernetes.io/managed-by=Helm
                     app.kubernetes.io/name=amazon-cloudwatch-observability
                     app.kubernetes.io/version=1.0.0
Annotations:         meta.helm.sh/release-name: amazon-cloudwatch-observability
                     meta.helm.sh/release-namespace: amazon-cloudwatch
Image pull secrets:  <none>
Mountable secrets:   <none>
Tokens:              <none>
Events:              <none>
@kikuoemoto
Copy link

@Blunderchips I believe the PR #78 addresses this issue.

@Blunderchips
Copy link
Author

@Blunderchips I believe the PR #78 addresses this issue.

Yes looks like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants