Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Fluentbit with ADOT Container Logs Collector #261

Closed
wants to merge 2 commits into from

Conversation

iamsouravin
Copy link

What does this PR do?

Replaces fluentbit logs with ADOT Container Logs Collector. fixes #247

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

With the announcement of ADOT Container Logs Collector support natively in Amazon EKS ADOT add-on customers no longer need to deploy an additional Fluentbit logs collector. ADOT add-on can now automatically manage the container logs collector daemonset through add-on configuration.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR
  • Yes, I have added a new example under examples to support my PR (when applicable)
  • Yes, I have updated the Pages for this feature

Note: Not all the PRs required examples and docs.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@@ -20,18 +20,19 @@ to enable Amazon CloudWatch as a data source. Make sure to provide permissions.
Amazon CloudWatch data source has already been setup for you.

All logs are delivered in the following CloudWatch Log groups naming pattern:
`/aws/eks/observability-accelerator/{cluster-name}/{namespace}`. Log streams
follow `{container-name}.{pod-name}`. In Grafana, querying and analyzing logs
`/aws/eks/observability-accelerator/{cluster-name}/workloads`. Log streams
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to keep logs separated per namespace? that was one of our requests before, and it this allows different patterns per log group (subscriptions, log class ...)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to find an elegant way to achieve this as currently the ADOT operator addon config schema supports only $CLUSTER_NAME and $NODE_NAME configuration variables for CW logs exporter. Container Logs configurable values

@bonclay7
Copy link
Member

Closing this as discussed

@bonclay7 bonclay7 closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Container Logs Collector Configuration for ADOT add-on
2 participants