Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: .NET Framework Templates #64

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

csantos
Copy link

@csantos csantos commented Apr 19, 2022

Issue #, if available:

resolves #63

Description of changes:

This pull request includes a load balanced application hosted on a Windows ECS Fargate service with a CI/CD pipeline that follows the architecture used in the .NET Framework CI/CD for Amazon ECS AWS Quick Start

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

csantos added 20 commits March 22, 2022 13:06
- Consistent use of single quotes
- Use of shorthand yaml syntax
- Removed default image
- Removed unsupported container configuraitons
- Updated default container image (used for initial svc deployment)
- Corrected IAM permissions, param data types
- Centralized CW logs to two log groups (service/service-name) and (service/pipeline)
- Added validation of zip file extension
- Removed duplicate IAM perms
- ID at Execution Time
Previously SSM param was resolved by using a CF parameter. This led to the SSM doc having the resolved AMI ID as the default value, not the SSM param name. This leads to essentially hard coding the AMI ID at the time that the CF stack is created. SSM doc should resolve the SSM param at time of execution.
- Added Operating System Family parameter since the SSM parameter could point to an AMI ID for various OSs
- Sync'd pipeline templates between public and private services
- Sync'd private and lb service templates
- Corrected private template's schema
- Changed to use only the load balancer version for .NET Fx assuming that customers would move existing workloads to Windows containers as is, typically a three tier app. They wouldn't need the private version of a Fargate service since most .NET Fx workloads are monoliths and the private service implied a decomposition to microservices. We found it unlikely that customers would stick with .NET Fx if they were decomposing their application.
This is needed when using using the GitHub integration feature of Proton
echo *** was listing out the directory contents.
@csantos csantos changed the title Feature/netfx template feature: .NET Framework Templates Apr 19, 2022
@csantos
Copy link
Author

csantos commented May 18, 2022

Just wanted to check in on this pull request. Been a little while since it was initiated. Any update would be appreciated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sample for .NET Framework with Windows CI/CD Pipeline
1 participant