Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying Project Path with WSL Path Fails #628

Closed
ashovlin opened this issue Jun 20, 2022 · 3 comments
Closed

Specifying Project Path with WSL Path Fails #628

ashovlin opened this issue Jun 20, 2022 · 3 comments
Labels
bug This issue is a bug. p2 This is a standard priority issue queued

Comments

@ashovlin
Copy link
Member

Describe the bug
Specifying a --project-path from Windows with a WSL path fails

dotnet aws deploy --project-path \\\\wsl$\\Ubuntu\\home\\path\\to\\project.csproj

Failed to find a valid .csproj or .fsproj file at path \\\\wsl$\\Ubuntu\\home\\path\\to\\project.csproj

Originally reported via the VS Toolkit - aws/aws-toolkit-visual-studio#263

Expected behavior
Not entirely sure if this is expected to work. Per #311 we're determining paths that start with \\ are invalid, but looks like this was to prevent SMB shared paths, not necessarily WSL.

Environment (please complete the following information):

  • CLI Version: [eg. 1.0.0] 0.47.26
  • Include the output of dotnet --info

This is a 🐛 bug report

@ashishdhingra ashishdhingra added bug This issue is a bug. p1 This is a high priority issue queued labels Dec 13, 2022
@ashishdhingra ashishdhingra added p2 This is a standard priority issue and removed p1 This is a high priority issue labels May 25, 2023
@ashishdhingra
Copy link
Contributor

WSL path has pattern as \\wsl$\[distro name]. So essentially, if deployment is expected to happen from a WSL path, then the check here should be modified to exclude \\wsl$ path.

@ashishdhingra
Copy link
Contributor

Per discussion with team, it's fine to close this issue since it is already in the backlog (there are no reactions from community as well).

Copy link

github-actions bot commented Nov 6, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue queued
Projects
None yet
Development

No branches or pull requests

2 participants