Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding internal functions for ML-DSA #1977

Closed
wants to merge 3 commits into from
Closed

Conversation

jakemas
Copy link
Contributor

@jakemas jakemas commented Nov 8, 2024

Issues:

Resolves #CryptoAlg-2723

Description of changes:

Adding the internal functions as defined in FIPS 204:

  • Algorithm 6 ML-DSA.KeyGen_internal
  • Algorithm 7 ML-DSA.Sign_internal
  • Algorithm 8 ML-DSA.Verify_internal

The re-write of Algorithm 7 and 8 is now consistent with upstream pq-crystals/dilithium@444cdcc.

Call-outs:

Upstream has no implementation of Algorithm 6 ML-DSA.KeyGen_internal, so this is AWS-LC specific.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@jakemas jakemas requested a review from a team as a code owner November 8, 2024 19:05
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (a11d73c) to head (8e2a69e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1977      +/-   ##
==========================================
+ Coverage   78.75%   78.77%   +0.02%     
==========================================
  Files         590      590              
  Lines      101482   101506      +24     
  Branches    14397    14400       +3     
==========================================
+ Hits        79920    79964      +44     
+ Misses      20928    20907      -21     
- Partials      634      635       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakemas jakemas marked this pull request as draft November 11, 2024 16:47
@jakemas
Copy link
Contributor Author

jakemas commented Nov 18, 2024

See #1999

@jakemas jakemas closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants