Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is http2 allowed to be passed to AWSXRay.captureHTTPsGlobal? #579

Open
kitsunde opened this issue Apr 3, 2023 · 3 comments
Open

Is http2 allowed to be passed to AWSXRay.captureHTTPsGlobal? #579

kitsunde opened this issue Apr 3, 2023 · 3 comments
Labels

Comments

@kitsunde
Copy link

kitsunde commented Apr 3, 2023

The type definition for captureHTTPsGlobal does not include http2. Is it supported?

export function captureHTTPsGlobal(mod: typeof https | typeof http, downstreamXRayEnabled?: boolean, subsegmentCallback?: httpSubsegmentCallback): void;
@carolabadeer
Copy link
Contributor

Hi @kitsunde,
The X-Ray Node SDK does not currently support instrumentation for HTTP2, which is why it is not included in the type definitions for captureHTTPs functions. However, there is an open feature request for support for HTTP2 in the opentelemetry-js repo, which I have followed up on.
I would recommend keeping an eye on that issue to see if/when opentelemetry plans to support HTTP2 instrumentation, and we are always happy to review any feature contributions if you are open to making a PR!

@kitsunde
Copy link
Author

kitsunde commented Apr 11, 2023

I see thank you. Is the idea that X-Ray will not continue to be built upon beyond maintenance? The language and in the repo is a bit vague.

@carolabadeer
Copy link
Contributor

HTTP2 instrumentation is not currently on our roadmap for instrumentation support, but we are still welcoming and reviewing any feature contributions for the X-Ray SDKs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants