Refactor to use display entities #698
Open
+1,706
−933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcginnes
force-pushed
the
display-entities
branch
4 times, most recently
from
a5f20a5
to
27336ba
Compare
kmcginnes
force-pushed
the
display-entities
branch
3 times, most recently
from
722543b
to
ed9b9a0
Compare
kmcginnes
force-pushed
the
display-entities
branch
from
ed9b9a0
to
a66e7c6
Compare
kmcginnes
commented
Dec 4, 2024
|
|
||
| // Map all the attributes for displaying | ||
| const typeAttributes = get( | ||
| vertexTypeAttributesSelector(vertex.types ?? [vertex.type]) |
There was a problem hiding this comment.
Use vertexTypes from above
kmcginnes
commented
Dec 4, 2024
| typeAttributes: AttributeConfig[], | ||
| textTransform: (text?: string) => string | ||
| ): DisplayAttribute[] { | ||
| const nodeAttributeNames = Object.keys(entity.attributes); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nearly all views that show details of a node, edge, or type would do the exact same transformations at the view level. This change abstracts all of that logic to a single place, ensuring the logic is consistent and making it easier to modify the behavior across the app.
The next step of this refactoring will be to abstract the neighbor count logic to the same
DisplayVertex. And after that we will have a good foundation for loading a node/edge from a simple ID, which is foundational to URL sharing.Validation
Related Issues
Check List
license.
pnpm checksto ensure code compiles and meets standards.pnpm testto check if all tests are passing.Changelog.md.