Add retries for get cluster credentials API call and remove unused variables #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The branch has merge conflicts |
|
I see that retries is always set to 10. Do we want to make the number of retries configurable to the end user? To me retries are super valuable when there is operational or connection error that can be solved by simply retrying, but sometimes we also want it to fail fast and fail early, such as when the user configuration is wrong. |
|
@karle-nishi resolved the merge conflicts. @jiezhen-chen - I was thinking that we could keep it at 10 for now and then pivot if there is a need for customization. i.e. I'm not completely sure this needs to even be exposed to the outside world. |
jiezhen-chen
approved these changes
Sep 15, 2023
karle-nishi
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…riables
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.