Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uploading the replay worker logs to s3 #133

Merged
merged 3 commits into from
Nov 27, 2023
Merged

uploading the replay worker logs to s3 #133

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a117990
uploading the replay worker logs to s3
DevanathanSabapathy1 Nov 21, 2023
122e97a
simplifying code to upload logs to s3
DevanathanSabapathy1 Nov 22, 2023
272bd06
removing redundant logging
DevanathanSabapathy1 Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions core/replay/replay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,20 +188,22 @@ def main():
# uploading replay logs to s3

bucket = bucket_dict(config["workload_location"])
object_key = "replay_logs.zip"
zip_file_name = f"replay_logs.zip"
if bucket.get("bucket_name", ""):
logger.info(f"Uploading replay logs to {bucket['bucket_name']}/{bucket['prefix']}")
dir = f"core/logs/replay/replay_log-{replay_id}"
with zipfile.ZipFile(zip_file_name, "w", zipfile.ZIP_DEFLATED) as zip_object:
for folder_name, sub_folders, file_names in os.walk(dir):
for filename in file_names:
file_path = os.path.join(folder_name, filename)
zip_object.write(file_path)
with open(zip_file_name, "rb") as f:
aws_service_helper.s3_put_object(
f, bucket["bucket_name"], f"{bucket['prefix']}{object_key}"
)
for log_type, directory in [("replay_logs","core/logs/replay/replay_log"), ("replay_worker_logs","core/logs/replay_log")]:
object_key = f"{log_type}.zip"
zip_file_name = f"{log_type}.zip"
dir = f"{directory}-{replay_id}"
with zipfile.ZipFile(zip_file_name, "w", zipfile.ZIP_DEFLATED) as zip_object:
for folder_name, sub_folders, file_names in os.walk(dir):
for filename in file_names:
file_path = os.path.join(folder_name, filename)
zip_object.write(file_path)
with open(zip_file_name, "rb") as f:
aws_service_helper.s3_put_object(
f, bucket["bucket_name"], f"{bucket['prefix']}{object_key}"
)

else:
logger.info("Invalid bucket name")

Expand Down