Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bucketLifecycle): allow for prefix #214

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

richardkeit
Copy link
Contributor

@richardkeit richardkeit commented Jul 20, 2023

In the case of the central logs bucket (log-centralization-methods), there are 16 different prefixes that logs are aggregated within the single bucket.

Without the ability to assign a prefix, each bucket only has the ability for a bucket wide S3 transition plan.

This allows logs from different sources to be transitioned at different periods.

  • Need some assistance with updating snapshots
  • Need some assistance updating docs

Further move, reports.costAndUsageReport.lifecycleRules does not add a rule prefix in the central bucket (as one might expect):

reports:
  costAndUsageReport:
    ...
    lifecycleRules:
      - enabled: true
        abortIncompleteMultipartUpload: 7
        expiration: 111
        noncurrentVersionExpiration: 111

Screenshot 2023-07-26 at 2 17 29 pm

transitions,
noncurrentVersionTransitions,
noncurrentVersionExpiration: cdk.Duration.days(lifecycleRuleConfig.noncurrentVersionExpiration),
expiredObjectDeleteMarker: lifecycleRuleConfig.expiredObjectDeleteMarker,
id: `LifecycleRule${this.props.s3BucketName}`,
});
id: `LifecycleRule${this.props.s3BucketName}${lifecycleRuleConfig.prefix}`,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a suffix? 😅😬

@richardkeit richardkeit marked this pull request as ready for review July 23, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants