-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bucketLifecycle): allow for prefix #214
Open
richardkeit
wants to merge
3
commits into
awslabs:main
Choose a base branch
from
richardkeit:feat/bucket-prefix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardkeit
force-pushed
the
feat/bucket-prefix
branch
from
July 20, 2023 08:57
893278d
to
26a692b
Compare
pwmcintyre
reviewed
Jul 21, 2023
source/packages/@aws-accelerator/accelerator/lib/stacks/logging-stack.ts
Outdated
Show resolved
Hide resolved
pwmcintyre
reviewed
Jul 21, 2023
source/packages/@aws-accelerator/constructs/lib/aws-s3/bucket.ts
Outdated
Show resolved
Hide resolved
pwmcintyre
reviewed
Jul 21, 2023
transitions, | ||
noncurrentVersionTransitions, | ||
noncurrentVersionExpiration: cdk.Duration.days(lifecycleRuleConfig.noncurrentVersionExpiration), | ||
expiredObjectDeleteMarker: lifecycleRuleConfig.expiredObjectDeleteMarker, | ||
id: `LifecycleRule${this.props.s3BucketName}`, | ||
}); | ||
id: `LifecycleRule${this.props.s3BucketName}${lifecycleRuleConfig.prefix}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a suffix? 😅😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of the central logs bucket (log-centralization-methods), there are 16 different prefixes that logs are aggregated within the single bucket.
Without the ability to assign a prefix, each bucket only has the ability for a bucket wide S3 transition plan.
This allows logs from different sources to be transitioned at different periods.
Further move,
reports.costAndUsageReport.lifecycleRules
does not add a rule prefix in the central bucket (as one might expect):