Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validation): Cost and Reporting Additional Artifacts #217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

richardkeit
Copy link
Contributor

Description of changes:

Currently additionalArtifacts is defined a list...

A list of manifests that you want Amazon Web Services to create for this report.

Defined in global-config.yaml as:

reports:
  costAndUsageReport:
...
    additionalArtifacts:
      - ATHENA

Specification as a list leans the user to believe multiple values can be supplied.

This is not supported:
image

image

Validation working with:

reports:
  costAndUsageReport:
...
    # Lacking clean docs: https://github.com/awslabs/landing-zone-accelerator-on-aws/blob/8c306e92e9c407973a65b75d7a5fa58cf3c6b81c/source/packages/@aws-accelerator/config/lib/global-config.ts#L115
    additionalArtifacts:
      - ATHENA
      - QUICKSIGHT
image

@richardkeit
Copy link
Contributor Author

Hi @erwaxler ,

This is another quality of life improvement around validation of config.
Can you please advise how we can have this incorporated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant