fix(constructs): service linked role missing permissions #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @richardkeit, Thank you for taking the time to create this MR. Our team is reviewing this change and we will get back to you if we have any questions! |
|
Hi @hickeydh-aws, I raised AWS Support case (173084606300187), attaching Cloudtrail logs for evidence of the missing permission. Also hoping for #611 that I raised to be merged in (first), given there is duplicate of the update snapshots due to issue #624 |
|
Thank you for the extra context. We will evaluate the above PRs as well. |
# Conflicts: # source/packages/@aws-accelerator/installer/test/__snapshots__/installer.test.ts.snap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#629
Description of changes:
Adds permission that was required.
Note: Still issues with snapshots raised in #624 & attempted to be fixed #611
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.