Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue where Ki,Mi,Gi,Ti,Pi behave like K,KB etc instead of KiB. #1827

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Oct 16, 2024

  1. Fixes issue where Ki,Mi,Gi,Ti,Pi behave like K,KB etc instead of KiB.

    As described in issue 1618, the Ki,Mi,etc units do not behave as expected.
    The code in parse.c explicitly handles K,KB and KiB, but not Ki,
    this results in Ki being implicitly handled by the "K" check.
    This commit adds explicit handling of Ki,Mi, etc to match the behavior of
    KiB, MiB, etc.
    This change also brings the behaviour in line with the documentation,
    though the examples have incorrect numbers for TB and have duplicated
    entries between kb_base=1000 and kb_base=1024.
    
    Sean Ashton <[email protected]>
    RobertTheBrucey committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6c911a3 View commit details
    Browse the repository at this point in the history