Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yul's grammar with smoke test using AST #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

leonardoalt
Copy link
Collaborator

@leonardoalt leonardoalt commented Sep 15, 2018

Opening again because #1 had some compilation errors and #2 couldn't be reopened due to force push.
Also the use if if_statement was missing from the grammar in https://solidity.readthedocs.io/en/v0.4.25/julia.html and yul.pest.
The test file is still main.rs because I don't know yet how to handle modules properly in Rust, so it all fails if it's not main.

Copy link

@jakelang jakelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think all that needed to be fixed with that grammar was renaming "if" to something else.

@jakelang
Copy link

@leonardoalt maybe rename from example1.yul to something more descriptive like empty_function_body.yul or power.yul.

@leonardoalt
Copy link
Collaborator Author

@jakelang Yea, also for me it complained about '"' -> "\"". Anyway, it doesn't really matter which PR is merged. I actually created this because I wanted to push some Rust tests along so I needed a compiling version (would rebase after #1 was merged).

@leonardoalt leonardoalt changed the title Yul's grammar [WIP] Yul's grammar Sep 16, 2018
@leonardoalt leonardoalt changed the title [WIP] Yul's grammar [WIP] Yul's grammar with tests Sep 16, 2018
@jakelang
Copy link

@leonardoalt your PR has my grammar in it with the fixes so let's just merge this one.

@leonardoalt leonardoalt changed the title [WIP] Yul's grammar with tests Yul's grammar with smoke test using AST Sep 18, 2018
@leonardoalt
Copy link
Collaborator Author

@jakelang @axic Ready for review

src/yul.pest Outdated Show resolved Hide resolved
Copy link

@jakelang jakelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leonardoalt leonardoalt mentioned this pull request Nov 20, 2018
@leonardoalt
Copy link
Collaborator Author

Updated the grammar with the modifications from #7

chriseth pushed a commit to chriseth/yultsur that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants