-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yul's grammar with smoke test using AST #3
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think all that needed to be fixed with that grammar was renaming "if" to something else.
@leonardoalt maybe rename from example1.yul to something more descriptive like |
@leonardoalt your PR has my grammar in it with the fixes so let's just merge this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
b8bd6ef
to
c6029d9
Compare
Updated the grammar with the modifications from #7 |
Opening again because #1 had some compilation errors and #2 couldn't be reopened due to force push.
Also the use if
if_statement
was missing from the grammar in https://solidity.readthedocs.io/en/v0.4.25/julia.html andyul.pest
.The test file is still main.rs because I don't know yet how to handle modules properly in Rust, so it all fails if it's not main.