From eef553c51c0d7a9687e097f3443ea1560c660b08 Mon Sep 17 00:00:00 2001
From: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
Date: Fri, 20 Oct 2023 16:58:05 -0700
Subject: [PATCH] [chore] add getters to `PoseidonCompactChunkInput` (#196)

chore: add getters to `PoseidonCompactChunkInput`
---
 halo2-base/src/poseidon/hasher/mod.rs | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/halo2-base/src/poseidon/hasher/mod.rs b/halo2-base/src/poseidon/hasher/mod.rs
index 6f2fc86c..b7d16ea8 100644
--- a/halo2-base/src/poseidon/hasher/mod.rs
+++ b/halo2-base/src/poseidon/hasher/mod.rs
@@ -8,7 +8,7 @@ use crate::{
     ScalarField,
 };
 
-use getset::Getters;
+use getset::{CopyGetters, Getters};
 use num_bigint::BigUint;
 use std::{cell::OnceCell, mem};
 
@@ -53,13 +53,16 @@ impl<F: ScalarField, const T: usize, const RATE: usize> PoseidonHasherConsts<F,
 }
 
 /// 1 logical row of compact input for Poseidon hasher.
-#[derive(Copy, Clone, Debug)]
+#[derive(Copy, Clone, Debug, Getters, CopyGetters)]
 pub struct PoseidonCompactInput<F: ScalarField, const RATE: usize> {
     // Right padded inputs. No constrains on paddings.
+    #[getset(get = "pub")]
     inputs: [AssignedValue<F>; RATE],
     // is_final = 1 triggers squeeze.
+    #[getset(get_copy = "pub")]
     is_final: SafeBool<F>,
     // Length of `inputs`.
+    #[getset(get_copy = "pub")]
     len: AssignedValue<F>,
 }
 
@@ -89,11 +92,13 @@ impl<F: ScalarField, const RATE: usize> PoseidonCompactInput<F, RATE> {
 }
 
 /// A compact chunk input for Poseidon hasher. The end of a logical input could only be at the boundary of a chunk.
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug, Getters, CopyGetters)]
 pub struct PoseidonCompactChunkInput<F: ScalarField, const RATE: usize> {
     // Inputs of a chunk. All witnesses will be absorbed.
+    #[getset(get = "pub")]
     inputs: Vec<[AssignedValue<F>; RATE]>,
     // is_final = 1 triggers squeeze.
+    #[getset(get_copy = "pub")]
     is_final: SafeBool<F>,
 }
 
@@ -105,13 +110,13 @@ impl<F: ScalarField, const RATE: usize> PoseidonCompactChunkInput<F, RATE> {
 }
 
 /// 1 logical row of compact output for Poseidon hasher.
-#[derive(Copy, Clone, Debug, Getters)]
+#[derive(Copy, Clone, Debug, CopyGetters)]
 pub struct PoseidonCompactOutput<F: ScalarField> {
     /// hash of 1 logical input.
-    #[getset(get = "pub")]
+    #[getset(get_copy = "pub")]
     hash: AssignedValue<F>,
     /// is_final = 1 ==> this is the end of a logical input.
-    #[getset(get = "pub")]
+    #[getset(get_copy = "pub")]
     is_final: SafeBool<F>,
 }