FilterX null coalescing assignments #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAnno
added a commit
to MrAnno/axosyslog
that referenced
this pull request
Nov 28, 2024
Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
filterx-null-assign
branch
from
075856e
to
ed3bc2c
Compare
MrAnno
added a commit
to MrAnno/axosyslog
that referenced
this pull request
Nov 28, 2024
Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
filterx-null-assign
branch
from
ed3bc2c
to
a8375e7
Compare
alltilla
previously approved these changes
Nov 29, 2024
MrAnno
dismissed
alltilla’s stale review
The merge-base changed after approval.
Signed-off-by: László Várady <[email protected]>
This is a preparation step for introducing the =? assignment. We should evaluate operands consistently, and from now on, the evaluation order is from right to left. Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
This is a preparation step for introducing the =? assignment. We should evaluate operands consistently, and from now on, the evaluation order is from right to left. Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
filterx-null-assign
branch
from
a8375e7
to
3847726
Compare
alltilla
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
=??operator.It brings some performance improvement as well when constructs like the below are replaced with these operators:
Depends on #390