ci(workflow): fix set-env job (checkout + token) #814
Conversation
WalkthroughThe pull request introduces modifications to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #814 +/- ##
==========================================
+ Coverage 42.68% 42.98% +0.30%
==========================================
Files 112 113 +1
Lines 6281 6325 +44
==========================================
+ Hits 2681 2719 +38
- Misses 3476 3480 +4
- Partials 124 126 +2 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
.github/workflows/notify-release.yml (2)
Line range hint
64-73: Add error handling for optional environment variablesThe announcement template uses environment variables for social links without checking their existence. Consider adding conditional checks to prevent empty or malformed links.
# Resources 📄 Changelog: <https://github.com/${{ github.repository }}/releases/tag/${{ needs.set-env.outputs.tag }}> 🛠️ Official repo: <https://github.com/${{ github.repository }}> - 💬 Vibe with us on Discord: <${{ env.DISCORD_URL }}> - 🐦 Catch us on Twitter: <${{ env.TWITTER_URL }}> + ${{ env.DISCORD_URL && format('💬 Vibe with us on Discord: <{0}>', env.DISCORD_URL) }} + ${{ env.TWITTER_URL && format('🐦 Catch us on Twitter: <{0}>', env.TWITTER_URL) }}🧰 Tools
🪛 actionlint
23-23: shellcheck reported issue in this script: SC2086:info:6:20: Double quote to prevent globbing and word splitting
(shellcheck)
23-23: shellcheck reported issue in this script: SC2295:info:8:31: Expansions inside ${..} need to be quoted separately, otherwise they match as patterns
(shellcheck)
23-23: shellcheck reported issue in this script: SC2086:info:9:32: Double quote to prevent globbing and word splitting
(shellcheck)
Line range hint
89-156: Consider reducing configuration duplication in documentation update jobsThe documentation update jobs contain repeated configuration patterns. Consider using a matrix strategy to reduce duplication and improve maintainability.
update-docs: runs-on: ubuntu-22.04 if: github.event_name != 'workflow_dispatch' strategy: matrix: docs: - {section: "modules", directory: "docs/proto/*"} - {section: "commands", directory: "docs/command/*"} - {section: "predicates", directory: "docs/predicate/*"} steps: - name: Update ${{ matrix.docs.section }} docs uses: fjogeleit/http-request-action@v1 with: url: "https://api.github.com/repos/axone-protocol/docs/actions/workflows/39152549/dispatches" method: "POST" customHeaders: '{"Accept": "application/vnd.github+json", "Authorization": "Bearer ${{ secrets.OPS_TOKEN }}"}' data: |- { "ref": "main", "inputs": { "version": "${{ github.event.release.tag_name }}", "repository": "${{github.repository}}", "section": "${{ matrix.docs.section }}", "docs_directory": "${{ matrix.docs.directory }}" } }🧰 Tools
🪛 actionlint
23-23: shellcheck reported issue in this script: SC2086:info:6:20: Double quote to prevent globbing and word splitting
(shellcheck)
23-23: shellcheck reported issue in this script: SC2295:info:8:31: Expansions inside ${..} need to be quoted separately, otherwise they match as patterns
(shellcheck)
23-23: shellcheck reported issue in this script: SC2086:info:9:32: Double quote to prevent globbing and word splitting
(shellcheck)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/notify-release.yml(2 hunks)
🔇 Additional comments (2)
.github/workflows/notify-release.yml (2)
18-20: LGTM: Repository checkout configuration is appropriate
The checkout action is correctly configured using the latest stable version (v4) and is appropriately placed before repository access operations.
Line range hint 1-17: LGTM: Workflow structure is well-organized
The workflow configuration demonstrates good practices:
- Clear job dependencies and execution flow
- Appropriate conditional execution
- Proper use of environment variables and secrets
🧰 Tools
🪛 actionlint
23-23: shellcheck reported issue in this script: SC2086:info:6:20: Double quote to prevent globbing and word splitting
(shellcheck)
23-23: shellcheck reported issue in this script: SC2295:info:8:31: Expansions inside ${..} need to be quoted separately, otherwise they match as patterns
(shellcheck)
23-23: shellcheck reported issue in this script: SC2086:info:9:32: Double quote to prevent globbing and word splitting
(shellcheck)
|
@coderabbitai resolve |
✅ Actions performedComments resolved and changes approved. |
Self explanatory.
Summary by CodeRabbit
New Features
Improvements