Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATACSeqQC.r: fails for single end sequences #1

Open
PollyTikhonova opened this issue Mar 12, 2020 · 3 comments
Open

ATACSeqQC.r: fails for single end sequences #1

PollyTikhonova opened this issue Mar 12, 2020 · 3 comments

Comments

@PollyTikhonova
Copy link

PollyTikhonova commented Mar 12, 2020

I've got a error in shiftGAlignmentsList(gal) :
is(gal, "GAlignmentsList") is not TRUE

As far as I understand, that's because readBamFile has a parameter asMates=FALSE and, at this case, readBamFile generates A GAlignments object but not A GAlignmentsList object.

So, this part of the code is invalid

# works only when the input is single end
if (opt$PE == 0) {
	# shift the BAM file - forward strand by +4 bp
	possibleTag <- c("AS", "XN", "XM", "XO", "XG", "NM", "MD", "YS", "YT")
	gal <- readBamFile(bamfile, asMates=FALSE, bigFile=TRUE)
	shiftedBamfile <- paste0(outdir, '/shifted.bam')
	gal1 <- shiftReads(gal)
	export(gal1, shiftedBamfile)
	cat(sprintf("\n *** shifted bam file ****  \n"))
}```
@PollyTikhonova PollyTikhonova changed the title ATACSeqQC.r: does not work for single end sequences ATACSeqQC.r: fails for single end sequences Mar 12, 2020
@PollyTikhonova
Copy link
Author

And, by the way, I think it is better to set bigFile=TRUE parameter for readBamFile function.
(But I could be wrong, cause I did not use ATACSeqQC that much)

@ay-lab
Copy link
Owner

ay-lab commented Apr 3, 2020

HI @PollyTikhonova
Thanks for using our pipeline. If you are using the latest code (updated 5 Months ago), it avoids using ATACseqQC since we found some problems in importing this package. We have used deepTools to extract nucleosome free and nucleosome containing regions.

Are you using the script "Sample_ATACseqQC_script.r" by any chance? In such a case, we recommend not to use them. Rather, please run the "pipeline.sh" script.

@PollyTikhonova
Copy link
Author

I run this script on purpose, not as part of any of your pipelines. (just wanted to see how this tool works). But I understood you and will use your main script in future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants