Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Imagemagick module to list of modules to enable if on Pantheon. #3924

Open
trackleft opened this issue Dec 4, 2024 · 2 comments · May be fixed by #3925
Open

Add Imagemagick module to list of modules to enable if on Pantheon. #3924

trackleft opened this issue Dec 4, 2024 · 2 comments · May be fixed by #3925
Assignees
Labels
good first issue Good for newcomers

Comments

@trackleft
Copy link
Member

Motivation

I would like imagemagick to be installed across the board on Pantheon sites.

Is your feature request related to a problem? Please describe.

I don't want to have to enable the module manually each time I create a new site on Pantheon.

Proposed Resolution

Add imagemagick to the list here:
https://github.com/az-digital/az_quickstart/blob/main/az_quickstart.install#L39-L46

Describe the solution you'd like

See above

Describe alternatives you've considered

Leave everything as-is

Roles and Permissions considerations

A clear and concise description of how each of the following roles would be impacted by this change:

  • Anonymous user
  • Authenticated user
  • Content editor
  • Content administrator
  • Administrator

Additional context

Add any other context or screenshots about the feature request here.

@trackleft trackleft added the good first issue Good for newcomers label Dec 4, 2024
@joeparsons
Copy link
Member

I think we should also consider adding a DB update similar to these that we added before Quickstart 2.6.x to retroactively install the module on existing Pantheon sites that don't already have it installed:
https://github.com/az-digital/az_quickstart/blob/2.5.9/az_quickstart.install#L136-L150
https://github.com/az-digital/az_quickstart/blob/2.5.9/az_quickstart.install#L214-L228

@joeparsons joeparsons self-assigned this Dec 4, 2024
@joeparsons
Copy link
Member

We may also want to consider setting the imagemagick quality setting in hook_install() and hook_update_N() on Pantheon sites...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants