Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to override settings on application. #1

Open
trackleft opened this issue Oct 24, 2024 · 0 comments
Open

Add ability to override settings on application. #1

trackleft opened this issue Oct 24, 2024 · 0 comments

Comments

@trackleft
Copy link
Member

trackleft commented Oct 24, 2024

Motivation

I'd like to make my recipe slightly more flexible.

Is your feature request related to a problem? Please describe.

The problem is that the recipe is not one size fits all.

Proposed Resolution

Allow inputs for the two config options

  • quality
  • prepend

Describe the solution you'd like

input:
  quality:
    data_type: integer
    description: 'Define the image quality for image manipulations'
    constraints:
      NotBlank: []
      Range: 
        min: 0
        max: 100
    prompt:
      method: ask
      arguments:
        question: 'Define the image quality for image manipulations. Ranges from 0 to 100. Higher values mean better image quality but larger files.'
    default:
      source: config
      config: ['imagemagick.settings', 'quality']
      value: 92
  prepend:
    data_type: string
    description: 'The imagemagick prepend command. '
    prompt:
      method: ask
      arguments:
        question: 'Add any prepend commands.'
    default:
      source: config
      config: ['imagemagick.settings', 'prepend']
      value: '-limit memory 64MiB'
config:
  actions:
    system.image:
      simple_config_update:
        toolkit: imagemagick
    imagemagick.settings:
      simple_config_update:
        quality: ${quality}
        prepend: ${prepend}

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

The readme should also be updated to explain how to add optional inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant