Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 4.x #76

Open
Johnywhisky opened this issue Jan 10, 2022 · 2 comments
Open

Add support for Django 4.x #76

Johnywhisky opened this issue Jan 10, 2022 · 2 comments

Comments

@Johnywhisky
Copy link

Hello from Republic of Korea.

FYI, I was using django version 3 and python 3.7 in my project and I just upgrade these versions to Django 4.0.1 & Python 3.9

after that, Whenever I use the email service that consists of the django-amazon-ses, it returns this error.

File "/Users/johnyoun/.local/share/virtualenvs/my-env/lib/python3.9/site-packages/django_amazon_ses.py", line 11, in <module> pre_send = Signal(providing_args=["message"]) TypeError: __init__() got an unexpected keyword argument 'providing_args'

It seems that Django 4.0 no longer has a providing_args argument in Signal class!

Could you check this?

@jwalgran
Copy link
Member

Thanks for the report. I checked the Django 4.0 release notes that providing_args reaced the end of it's deprecation cycle and was removed.

https://docs.djangoproject.com/en/4.0/releases/4.0/#features-removed-in-4-0

Azeave depends on this module for several proejects but since we tend to deploy our projects on LTS releases of Django we have not yet scheduled an upgrade of this library.

@jwalgran jwalgran changed the title It seems that django-amazon-ses doesn't support django 4.0 Add support for Django 4.x Jan 13, 2022
@mustafa0x
Copy link

Fixed by #73 but a new release is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants