Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request Factions, Editing, Adding, Altering tables #732

Closed
Chromie-WoW opened this issue May 31, 2020 · 4 comments
Closed

Feature Request Factions, Editing, Adding, Altering tables #732

Chromie-WoW opened this issue May 31, 2020 · 4 comments
Labels
feature request wontfix This will not be worked on

Comments

@Chromie-WoW
Copy link

Chromie-WoW commented May 31, 2020

Although people would have to use a DBC editor to export their faction.dbc to csv or directly into database. It would be amazing to be able to see, edit, and add factions. Currently that i have found, there is no system out there that does faction editing, let alone explains it well. When there is so many parent > parent > child faction setups like Classic > Horde > Town and many more with multiple parents. No clear explanations of parent mods, flags and more.

Being able to make/choose a faction, choose its parent / make a new parent, edit values, change mods, allowing it to always display in reputation tab or hidden and sooo much more.

Being able to selection a faction and be able to see ALL the factions associated with it right there without searching through them all, so you know, 20, undead, is friendly with X and enemies with X and so forth.

A disclaimer up top of the faction page could tell people to make sure to export/import Faction.dbc Faction_template.dbc and factiongroup.dbc to database as "these names" so they can be read and edited.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Chromie-WoW Chromie-WoW changed the title Feature Request Factions. Feature Request Factions, Editing, Adding, Altering tables May 31, 2020
@Helias
Copy link
Member

Helias commented May 31, 2020

This is interesting, I don't know if Keira3 will edit DBC too, I hope so, but personally now is not the time to do that, I am personally waiting to have this azerothcore/azerothcore-wotlk#3002
and more free time 😅

@Chromie-WoW
Copy link
Author

Chromie-WoW commented Jun 2, 2020

It doesn't have to edit dbc. If you use wdbx, theres an export to DB. I do almost all my dbc work via db then import it back to wdbx. So by exporting the faction tables to your db, kiera3 can edit them, then wdbx import it back. Kiera3 can run the queries ON the DB exports. Then when the dbc in db update gets complete, the faction system in kiera would already be done.

@Helias
Copy link
Member

Helias commented Jun 2, 2020

You're right, we can edit the factions from the database because they are already present as SQL table in the DB.
Anyway, for now we focused on improving the current editors, I don't know when we will add more editors.

@Helias Helias added the wontfix This will not be worked on label Oct 27, 2024
@Helias
Copy link
Member

Helias commented Oct 27, 2024

I am closing this because I would not implement something that relies on 3rd tools like WDBX, moreover, it is unmaintained and not cross-platform.
Ideally, I would implement a DBC editor in Keira3 that allows to make the same conversions in CSV/SQL, I am closing this feature request but I'll keep in mind the idea of implementing client-editor tools in Keira3.

We have some porting of stormlib and dbc through https://github.com/sebyx07/wow-dbcfile-node/tree/main and https://github.com/sebyx07/stormlib-node , we could in the future implement them

EDIT: I made a separate issue for DBC editor #3109

@Helias Helias closed this as completed Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants