From 39bfa3269cddd8e041f586c8cac696e6d2e28d1f Mon Sep 17 00:00:00 2001
From: chian <91816369+chianw@users.noreply.github.com>
Date: Fri, 29 Sep 2023 12:08:11 +0800
Subject: [PATCH] Create before destroy for azuread (#1805)

* Update password.tf

* Update module.tf

* Update module.tf
---
 modules/azuread/applications/module.tf               | 2 +-
 modules/azuread/credentials/password.tf              | 8 ++++----
 modules/azuread/service_principal_password/module.tf | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/modules/azuread/applications/module.tf b/modules/azuread/applications/module.tf
index bfb5a89b2e..116f093e2b 100644
--- a/modules/azuread/applications/module.tf
+++ b/modules/azuread/applications/module.tf
@@ -128,7 +128,7 @@ resource "azuread_service_principal_password" "pwd" {
   }
 
   lifecycle {
-    create_before_destroy = false
+    #create_before_destroy = false
   }
 }
 
diff --git a/modules/azuread/credentials/password.tf b/modules/azuread/credentials/password.tf
index ec62163622..3592224614 100644
--- a/modules/azuread/credentials/password.tf
+++ b/modules/azuread/credentials/password.tf
@@ -11,7 +11,7 @@ resource "azuread_application_password" "key" {
   }
 
   lifecycle {
-    create_before_destroy = true
+    #create_before_destroy = true
   }
 }
 
@@ -28,7 +28,7 @@ resource "azuread_application_password" "key0" {
   }
 
   lifecycle {
-    create_before_destroy = true
+    #create_before_destroy = true
   }
 }
 
@@ -44,7 +44,7 @@ resource "azuread_application_password" "key1" {
   }
 
   lifecycle {
-    create_before_destroy = true
+    #create_before_destroy = true
   }
 }
 
@@ -89,4 +89,4 @@ resource "azurerm_key_vault_secret" "client_secret" {
   tags = {
     key = local.random_key
   }
-}
\ No newline at end of file
+}
diff --git a/modules/azuread/service_principal_password/module.tf b/modules/azuread/service_principal_password/module.tf
index 6cddbd5b61..2eeb0b2d38 100644
--- a/modules/azuread/service_principal_password/module.tf
+++ b/modules/azuread/service_principal_password/module.tf
@@ -8,7 +8,7 @@ resource "azuread_service_principal_password" "pwd" {
   }
 
   lifecycle {
-    create_before_destroy = false
+    #create_before_destroy = false
   }
 }