Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report- azurerm_logic_app_standard virtual_network_subnet_id is always reset when connecting to virtual network using azurerm_app_service_virtual_network_swift_connection #1975

Open
1 task done
arne21a opened this issue May 15, 2024 · 0 comments · May be fixed by #1978
Labels
bug Something isn't working

Comments

@arne21a
Copy link
Contributor

arne21a commented May 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Version of the module you are using

5.7.11

Rover Version

rover:1.4.6-2305.1807

Terraform Version

v1.4.6 on linux_arm64

AzureRM Provider Version

3.75.0

Affected Resource(s)/Data Source(s)

azurerm_logic_app_standard, azurerm_app_service_virtual_network_swift_connection

Terraform Configuration Files

logic_app_standard = {
  las1 = {
    name                 = "logicapp2"
    resource_group_key   = "la_test"
    app_service_plan_key = "asp1"
    storage_account_key  = "sa1"
    version              = "~4"
    # Required for virtual network integration
    vnet_integration = {
      vnet_key   = "vnet"
      subnet_key = "la_test_subnet"
      lz_key     = "sandbox_level3"
      # subnet_id = ""
    }
  }
}

Expected Behaviour

A azurerm_logic_app_standard and a azurerm_app_service_virtual_network_swift_connection is created. The azurerm_logic_app_standard recognizes the external configuration and does not overwrite it.

Actual Behaviour

A azurerm_logic_app_standard and a azurerm_app_service_virtual_network_swift_connection are created. The azurerm_app_service_virtual_network_swift_connection sets the subnet_id attribute of the azurerm_logic_app_standard which does not recognizes the external configuration and tries to overwrite it.
This issue is discussed in this issue with close to 50 upvotes:
hashicorp/terraform-provider-azurerm#17930

The issue mentions two possible workarounds:

  1. Lifecycle policy. Thats not an option with CAF
  2. Not using the azurerm_app_service_virtual_network_swift_connection. Instead use the subnet_id attribute of azurerm_logic_app_standard.

Option two works for us, but the change from azurerm_app_service_virtual_network_swift_connection to the subnet_id attribute comes with a downtime. Therfore i would consider this workaround a "breaking change" to CAF.

I will provide our solution as a PR, it is on the maintainers to decide if thats a good idea for everyone.

Steps to Reproduce

No response

Important Factoids

No response

References

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant