New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDN not found because of path.join in Kuromoji.js #12

Open

qqpann opened this issue Jul 12, 2021 · 2 comments

qqpann commented Jul 12, 2021 •

edited

Loading

https://nodejs.org/api/path.html#path_path_join_paths
https://github.com/takuyaa/kuromoji.js/blob/71ea8473bd119546977f22c61e4d52da28ac30a6/src/loader/DictionaryLoader.js#L51
After path.join, "https://" becomes "https:/" and causes 404 error in a browser.

In my use case, I use kuromojin in a web application and this results in "https://cdn.example.com/dict" to be "https://myapp.com/cdn.example.com/dict"and getTokenizer cannot find the dict files.

Author

qqpann commented Jul 12, 2021 •

edited

Loading

https://github.com/textlint/editor/blob/630fd1ee938a2b39e8ae74afdbde157497125557/packages/%40textlint/script-compiler/patch/kuromoji.js#L50
https://github.com/textlint/editor/blob/630fd1ee938a2b39e8ae74afdbde157497125557/packages/%40textlint/script-compiler/src/compiler.ts#L86
I found there is α repository that makes original patch to deal with τhis problem.
This might be α good reference.

Owner

azu commented Jul 12, 2021

takuyaa/kuromoji.js#37
This is kuromoji.js issue

azu closed this as completed

azu reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment