Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] SurfingKeys is not receiving settings in conf.js, especially hint alignment and hint characters #81

Open
masisley opened this issue Feb 11, 2024 · 1 comment

Comments

@masisley
Copy link

masisley commented Feb 11, 2024

  • Surfingkeys Version: 1.16.1
  • Surfingkeys-conf Version (git hash): c5052d6
  • Operating System: Windows
  • Browser Version: Chrome 121.0.6167.161

Details

It seems that surfingkeys is not properly receiving the settings json in conf.js. I suspect we are not properly setting it in a way that surfing keys understands:

settings: {
    hintAlign: "center",
    //hintCharacters: "qwertasdfgzxcvb",
    hintCharacters: "abcdefgilmnoprstuvwy",
    omnibarSuggestionTimeout: 500,
    richHintsForKeystroke: 1,
    defaultSearchEngine: "dd",
    theme,
  },

The hint alignment and characters are not respected. The settings are indeed dropped in my output file (without the comments), and other modifications i have made to conf.js and keys.js are respected. The configuration settings that are respected are:

siteleader: "s",

  // Leader for OmniBar searchEngines
  searchleader: "^",

I don't think i am missing any necessary setup steps.

@masisley
Copy link
Author

masisley commented Feb 11, 2024

A snippet from the dropped file

const De={settings:{hintAlign:"center",hintCharacters:"abcdefgilmnoprstuvwy",omnibarSuggestionTimeout:500,richHintsForKeystroke:1,defaultSearchEngine:"dd",theme:'\n  body {\n    font-family: "Input Mono", "DejaVu Sans Mono", DejaVu, Arial, sans-serif;\n    font-size: 12pt;\n  }\n\n  #sk_keystroke kbd {\n    font-family: "Sudo Nerd Font Mono", "Sudo Mono", "Sudo",\n      "Input Mono Nerd Font", "Input Mono", "DejaVu Sans Mono", "DejaVu", "Arial",\n      sans-serif;\n    font-size: 10pt;\n  }\n\n  #sk_omnibarSearchArea {\n    margin: 0 !

@masisley masisley changed the title [Bug] SurfingKeys is ignoring settings blob in conf.js, especially hint alignment and hint characters [Bug] SurfingKeys is not receiving settings in conf.js, especially hint alignment and hint characters Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant