Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] showEditor is gone from the latest version #89

Open
blacklight opened this issue Nov 16, 2024 · 2 comments
Open

[Bug] showEditor is gone from the latest version #89

blacklight opened this issue Nov 16, 2024 · 2 comments

Comments

@blacklight
Copy link

  • Surfingkeys Version: 1.17.4
  • Surfingkeys-conf Version (git hash): c51b1b8
  • Operating System: Arch Linux
  • Browser Version: Firefox 132.0.2

Details

The latest version of Surfingkeys and surfingkeys-conf seems to have broken text editor support (e.g. when typing gi).

Stack trace:

TypeError: yt.showEditor is not a function[content.js line 3 > Function:9:2774](moz-extension://458f783c-2e18-46d7-8ee6-047dbddcc98b/content.js%20line%203%20%3E%20Function)
    vimEditURL moz-extension://458f783c-2e18-46d7-8ee6-047dbddcc98b/content.js line 3 > Function:9
    callUserFunction moz-extension://458f783c-2e18-46d7-8ee6-047dbddcc98b/api.js:3
    <anonymous> moz-extension://458f783c-2e18-46d7-8ee6-047dbddcc98b/api.js:3
    e moz-extension://458f783c-2e18-46d7-8ee6-047dbddcc98b/content.js:3
    mapkey moz-extension://458f783c-2e18-46d7-8ee6-047dbddcc98b/content.js:3
    handleMapKey moz-extension://458f783c-2e18-46d7-8ee6-047dbddcc98b/content.js:3
    me moz-extension://458f783c-2e18-46d7-8ee6-047dbddcc98b/content.js:3
    ae moz-extension://458f783c-2e18-46d7-8ee6-047dbddcc98b/content.js:3
    keydown moz-extension://458f783c-2e18-46d7-8ee6-047dbddcc98b/content.js:3

It looks like showEditor is a function provided by the Surfingkeys API and it's still available in the latest release, so I'm not sure if something breaking change has been introduced.

@blacklight
Copy link
Author

A quick console.log seems to confirm that the Front object from the latest version of Surfingkeys no longer contains showEditor.

screenshot_2024-11-21T00:46:56

Seems to be related to this issue, which has a quite puzzling answer:

showEditor has never been exported before

I'm not sure if it was exported before but it shouldn't have been, or if this is a deliberate decision for some reason - maybe worth opening a PR on Surfingkeys to export it?

@b0o
Copy link
Owner

b0o commented Nov 21, 2024

Hey there. I haven't had time to look into this yet. If you would like to open an issue/PR with SurfingKeys, it would be appreciated!

blacklight added a commit to blacklight/Surfingkeys that referenced this issue Nov 21, 2024
It seems that `Front.showEditor` is no longer exported - probably as a
result of 728e011.

See: brookhong#2183
See: b0o/surfingkeys-conf#89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants