Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibilities with TYPO3 8.7.1 #58

Open
gianstraf opened this issue May 24, 2017 · 2 comments
Open

Incompatibilities with TYPO3 8.7.1 #58

gianstraf opened this issue May 24, 2017 · 2 comments

Comments

@gianstraf
Copy link

Hi,
the extension seo_basics (v.0.9.6) doesn't work properly with TYPO3 8.7.1.
We incontered this problems:

  • The class seo_basics/Classes/Tree/PageTreeView.php uses unexisting IconUtility::getSpriteIcon method.
    This causes a FATAL error:

Uncaught TYPO3 Exception: Class 'TYPO3\CMS\Backend\Utility\IconUtility' not found

We have replaced this line (method getTree):

$HTML_depthData = $depthData . IconUtility::getSpriteIcon('treeline-' . $LN);
with

/** @var \TYPO3\CMS\Core\Imaging\IconFactory $iconFactory */ $iconFactory = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Imaging\IconFactory::class); $icon = $iconFactory->getIcon( 'treeline-' . $LN, \TYPO3\CMS\Core\Imaging\Icon::SIZE_SMALL); $HTML_depthData = $depthData . $icon;

  • The class seo_basics/Classes/Tree/PageTreeView.php uses deprecated class TYPO3\CMS\Core\Database\DatabaseConnection.
    In method getDataNext ,
    the function call: $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)

causes this FATAL ERROR:

Core: Exception handler (WEB): Uncaught TYPO3 Exception: Call to undefined method Doctrine\DBAL\Driver\Mysqli\MysqliStatement::fetch_assoc() | Error thrown in file /var/www/project/htdocs/typo3_src-8.7.1/typo3/sysext/core/Classes/Database/DatabaseConnection.php in line 1131.

Currently we've modified properly the class DatabaseConnection to work fine with MysqliStatement, using method $res->fetch(\PDO::FETCH_ASSOC) instead of $res->fetch_assoc.

Thank you,
Gianluca

@breml
Copy link

breml commented Sep 14, 2017

@gianstraf Thanks for this, it helped me to get seo_basics to work with TYPO3 8.7.x.

@gianstraf
Copy link
Author

@breml you are welcome
When will it be available on TER ?

Thank you,
Gianluca

franzholz added a commit to franzholz/ke_smallads that referenced this issue Dec 13, 2018
  use $res->fetch(\PDO::FETCH_ASSOC) instead of $GLOBALS["TYPO3_DB"]->sql_fetch_assoc($res)
* include spaces according to Coding Guidelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants