Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default bind_address of http/tcp/stream to include ipv6? #1068

Open
jreusch opened this issue Oct 24, 2022 · 2 comments · May be fixed by #1290
Open

Change default bind_address of http/tcp/stream to include ipv6? #1068

jreusch opened this issue Oct 24, 2022 · 2 comments · May be fixed by #1290

Comments

@jreusch
Copy link
Contributor

jreusch commented Oct 24, 2022

I was at a friends home and the snapcast app worked flawlessly.
Coming back to my setup the app reported something about connection problems...
I could not figure it out, the auto discovered(!) hostname was right and i could access the 1780 port of this hostname.
Digging deeper with netstat on the snapserver i realized it's because its bound to 0.0.0.0 (ipv4 only) as default.

So changing bind_to_address in the http/tcp/stream section to :: (as opposed to the 0.0.0.0 default setting) did the trick.

That's why i'd suggest to change in server_settings.hpp the default to that one, as we have 2022 and ipv6 @home is not so uncommon quite anymore and this maybe helps other folks of having a nice out of the box behavior of snapcast :)

I know this would break devices where this setting is currently left on default and which do not have ipv6 stack loaded. But those most likely are more custom ones, as even default raspbian has ipv6 available since the early days.
What do you think?
@rnestler
Copy link

rnestler commented Sep 9, 2024

Would it make sense to first print a warning if the configuration value isn't set to 0.0.0.0 explicitly to smooth the transition? Something like: "warning bind_to_address not set. The default will change from 0.0.0.0 to :: in the next release"

@ernstkl
Copy link

ernstkl commented Oct 7, 2024

Snapchat server should by default try and bind to both ipv4 and ipv6 address. For all three ports/services.

Because the current ipv4 only default creates problems for dual stack clients, which might try to connect via ipv6 as a standard preference.

Question is how to change the code accordingly. Is the argument of bind_to_address a list, where "::" could just be added?

@ernstkl ernstkl linked a pull request Oct 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rnestler @jreusch @ernstkl