-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
via annular ring #24
Comments
I can't reproduce this. Is svg2shenzhen up to date? If it is, can you share the file where this happens? |
Oops, actually I can reproduce this: I can see it in Gerbers but not in KiCad. I guess KiCad adds the ring. The solution is probably to mark these holes NPTH (non-plated through-hole) but then they will also be put into the NPTH.drl file unless you check an option to merge them. Still makes the most sense since they could in fact be NPTH. |
so to clarify, NPTH: 2 post script options
btw. the source is here |
By "the script" you mean svg2shenzhen? Currently it adds though-hole pads with the copper and mask the same size as the hole. So yeah, your two workarounds should work. We should fix this in svg2shenzhen though. |
@kasbah can you direct me to the location of the drill creation in the svg2shenzhen script? |
svg2shenzhen/inkscape/svg2shenzhen/export.py Lines 619 to 627 in fb80c3a
I think we can change those to I played around a bit and noticed there is still a solder mask expansion around the non-plated holes. I believe that may be needed anyway. |
Where did you see the solder mask expansion? In the exported gerbers? |
yes, its an auto expansion done by kicad to all thru holes. you can choose to disable that expansion inside kicad. by right click/editing each pad before you export to gerber (maybe even change the default template in kicad, idk) i use a kicad script (#25) to bypass the kicad GUI stage altogether so i erase any kicad "addons" i dont like directly at the gerber stage. using gerber viewer and editor(!) > gerbv <3 |
I changed export.py to support an optional Drill-NP layer, that generates non-plated holes. |
reproduce:
this is contrary to the TIPS section in readme
to combat this i erase the ring in gerbv (gerbv is awesome)
The text was updated successfully, but these errors were encountered: