Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

via annular ring #24

Open
5shekel opened this issue May 19, 2018 · 9 comments
Open

via annular ring #24

5shekel opened this issue May 19, 2018 · 9 comments
Labels
good first issue Good for newcomers

Comments

@5shekel
Copy link
Contributor

5shekel commented May 19, 2018

reproduce:

  • create a (0.6mm) circle in drill layer
  • a 1mm copr ring around it is generated automatically in copper layer.

this is contrary to the TIPS section in readme

For Drill layers, place circle objects and they will be converted into drill pads in KiCad with the same diameter. These drills will not have annular rings unless you also add copper to the F.Cu and B.Cu layers. Don't use any groups on Drill layers either.

to combat this i erase the ring in gerbv (gerbv is awesome)

@kasbah
Copy link
Collaborator

kasbah commented May 20, 2018

I can't reproduce this. Is svg2shenzhen up to date? If it is, can you share the file where this happens?

@kasbah
Copy link
Collaborator

kasbah commented May 20, 2018

Oops, actually I can reproduce this: I can see it in Gerbers but not in KiCad. I guess KiCad adds the ring. The solution is probably to mark these holes NPTH (non-plated through-hole) but then they will also be put into the NPTH.drl file unless you check an option to merge them. Still makes the most sense since they could in fact be NPTH.

@5shekel
Copy link
Contributor Author

5shekel commented May 20, 2018

so to clarify,
the diff between a NPTH and thru hole is
Thru hole:
the script adds ring in mask and copper layer (front and back) to all drill holes, by default

NPTH: 2 post script options

  1. edit hole in kicad, so its specified as NPTH or Thru Hole(by default)
  2. erase the ring from all affected layers in gerber editor (gerbv) which will basically turn it into an NPTH

btw. the source is here
using release (0.2.13)

@kasbah
Copy link
Collaborator

kasbah commented May 20, 2018

By "the script" you mean svg2shenzhen? Currently it adds though-hole pads with the copper and mask the same size as the hole. So yeah, your two workarounds should work. We should fix this in svg2shenzhen though.

@5shekel
Copy link
Contributor Author

5shekel commented May 21, 2018

@kasbah can you direct me to the location of the drill creation in the svg2shenzhen script?
i want to experiment and a bit lost .

@kasbah
Copy link
Collaborator

kasbah commented May 21, 2018

if kicad_mod:
pad_template = "(pad {n} thru_hole circle (at {x} {y}) (size {d} {d}) (drill {d}) (layers *.Cu *.Mask))\n"
else:
pad_template = """
(module Wire_Pads:SolderWirePad_single_0-8mmDrill (layer F.Cu) (tedit 0) (tstamp 5ABD66D0)
(at {x} {y})
(pad {n} thru_hole circle (at 0 0) (size {d} {d}) (drill {d}) (layers *.Cu *.Mask))
)
"""

I think we can change those to np_thru_hole rather than thru_hole. I believe we can also remove the pad names ({n}) with "" since it makes even less sense to give them names.

I played around a bit and noticed there is still a solder mask expansion around the non-plated holes. I believe that may be needed anyway.

@kasbah kasbah added the good first issue Good for newcomers label May 21, 2018
@4b11b4
Copy link

4b11b4 commented Oct 26, 2018

I played around a bit and noticed there is still a solder mask expansion around the non-plated holes. I believe that may be needed anyway.

Where did you see the solder mask expansion? In the exported gerbers?
Just wondering if it might be due to local or global mask clearances that would not be due to svg2shenzen.

@5shekel
Copy link
Contributor Author

5shekel commented Oct 26, 2018

yes, its an auto expansion done by kicad to all thru holes.

you can choose to disable that expansion inside kicad. by right click/editing each pad before you export to gerber (maybe even change the default template in kicad, idk)

i use a kicad script (#25) to bypass the kicad GUI stage altogether so i erase any kicad "addons" i dont like directly at the gerber stage. using gerber viewer and editor(!) > gerbv <3

@drayde
Copy link

drayde commented Nov 3, 2019

I changed export.py to support an optional Drill-NP layer, that generates non-plated holes.
In case you think this is useful not just for me, check out the PR I created: #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants