machinepack-postgresql may not be cleaning up properly after tests

[alxndrsn]

machinepack-postgresql uses mochajs 3.0.2 which is over 3 years old.

When upgraded to the latest version of mocha, mocha does not exit at the end of the test run. This can be fixed by adding the --exit flag to the mocha call, suggesting it is caused by the breaking change in mocha v4 (September 2017) such that:

If the mocha process is still alive after your tests seem "done", then your tests have scheduled something to happen (asynchronously) and haven't cleaned up after themselves properly. Did you leave a socket open?
--https://boneskull.com/mocha-v4-nears-release/#mochawontforceexit

[sailsbot]

@alxndrsn Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[alxndrsn]

It looks like this is because the manager is not destroyed in test/integration/connectable/get-connection.js.

I've tried adding an after() function which calls manager.pool.end() in this test, but the callback passed to end() is never triggered.

[alxndrsn]

Fix submitted at sailshq/machinepack-postgresql#29

[johnabrams7]

@alxndrsn Appreciate the PR, we'll have it checked out. 👍

[mikermcneil]

@alxndrsn added a tweak - would you let me know if that makes sense to you? If so we can go ahead and merge this

[alxndrsn]

@mikermcneil with your tweak, release() is no longer called. I suspect this undoes the intention of the bugfix...