-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect url_key's which aren't normalized #14
Comments
We seem to have that also in url_path of categories ... not sure which bug caused that. Was that already checked? |
on the path-check I am also getting
which is kind of wrong ... |
According to https://github.com/elgentos/regenerate-catalog-urls#faq url_paths can be deleted, so you can ignore my previous comments. |
@amenk: sorry for the delay, I was away in holiday for the past 3 weeks. I'm quickly tuning in just to mention that only url_path's for products can be deleted, please don't delete them for categories, those are actually being used! As for your original question, I'll need to dig in a bit, it does sound like a bug at first sight, but I'll need some time in the coming days to get up to speed with all the things I missed during my holiday. |
I hope you enjoyed your holiday @hostep - no need to be sorry for the delay :-) We kind of solved it on staging by regenerating "everything" with the elgentos module and deleting In elgentos/magento2-regenerate-catalog-urls#48 and the FAQ @peterjaap writes that it's pretty safe to delete |
The FAQ only mentions products, not categories 😉 |
It does mention categories, but might imply that you regenerate anyways |
@amenk I updated the faq to not imply that ;) |
We should add some checks to see if url_key's in the database are normalized or not (contain unexpected characters). If they aren't normalized these can cause bad things.
Apparently there was a bug introduced in Magento 2.3.3 (which has been fixed in 2.4.0) which allowed this problem to happen.
So it would be nice if this tool could detect such problems.
The bug only existed for product url_keys, but maybe we should also check the categories, you never know ...
The text was updated successfully, but these errors were encountered: