V2 #46
Merged
V2 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: major Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: minor Signed-off-by: Phil Wilson <[email protected]>
Change-type: minor Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: minor Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: minor Signed-off-by: Phil Wilson <[email protected]>
piotr-cz
reviewed
Jan 28, 2021
This was
linked to
issues
Jan 28, 2021
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
tmigone
suggested changes
Jan 29, 2021
|
|
||
| # Set up the audio block. This won't have any effect if the audio block is not being used. | ||
| RUN curl -skL https://raw.githubusercontent.com/balenablocks/audio/master/scripts/alsa-bridge/debian-setup.sh| sh | ||
| ENV PULSE_SERVER=tcp:audio:4317 |
There was a problem hiding this comment.
Did you test the integration with the audio block? If not let me know and I can do it.
There was a problem hiding this comment.
@tmigone I haven't yet. If you wouldn't mind testing the block in general, and the audio link specifically, that would be much appreciated.
src/server.js
Outdated
|
|
||
| flags = []; | ||
| // If the user has set the flags, use them | ||
| if (null != FLAGS) |
There was a problem hiding this comment.
Not sure if there is any difference but I've almost never seen the variable on the right side of a comparison in js. It probably works exactly in the same way, so most likely a stylistic thing.
There was a problem hiding this comment.
@tmigone you're right - it's poor practice in any language, since accidentally typing '=' rather than '==' or '===' can create odd bugs which are hard to track down. It's my sloppiness coming out just because I'm hacking something in a language I don't fully get. :)
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Tomás Migone <[email protected]>
meta: add versionist
Change-type: patch Signed-off-by: Tomás Migone <[email protected]>
meta: run versionist to update balena.yml version
Change-type: major Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: minor Signed-off-by: Phil Wilson <[email protected]>
Change-type: minor Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: minor Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: minor Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Change-type: patch Signed-off-by: Phil Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.