Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a wider range of object label characters #12

Open
kb2ma opened this issue Sep 20, 2022 · 2 comments · May be fixed by #13
Open

Support a wider range of object label characters #12

kb2ma opened this issue Sep 20, 2022 · 2 comments · May be fixed by #13

Comments

@kb2ma
Copy link
Contributor

kb2ma commented Sep 20, 2022

Presently the acceptable characters for a label on a service, network, or value are limited to ASCII letters and numbers, plus period (.) and dash (-). Supervisor is expanding the set of acceptable characters to support services like traefik and caddy-docker-proxy.

We want to support this extension of acceptable characters across all balena tools. balena-cli relies on balena-compose for label validation.

@andoks
Copy link

andoks commented Jul 19, 2024

I just got an error Invalid label name: "caddy.handle_path". Label names must only contain alphanumeric characters, periods "." and dashes "-". when trying to do balena push using balena-cli 18.2.33 and supervisor v16.4.4 (and host os balenaOS 2.115.7+rev1) - I found balena-os/balena-supervisor#1949 and was thinking it should work with balena-os/balena-supervisor#2000 merged, but I still got the error. can #13 be merged now? I there a work-around for this?

@andoks
Copy link

andoks commented Jul 19, 2024

Related issue over at the lucaslorentz/caddy-docker-proxy project lucaslorentz/caddy-docker-proxy#362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants