Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder.buildDir should respect .dockerignore #6

Open
pipex opened this issue Jul 21, 2022 · 0 comments
Open

Builder.buildDir should respect .dockerignore #6

pipex opened this issue Jul 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@pipex
Copy link
Contributor

pipex commented Jul 21, 2022

Although the library has an option to create a build stream from an archive, Builder.buildDir is the most handy option building an image from a directory. However, if the directory has build files (e.g. node_modules, library files, etc), these will end up in the tar, delaying the build start. Having the method read from .dockerignore to skip files for the build, might be a way to solve the issue.

@pipex pipex added the enhancement New feature or request label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant